FeatherBB

Lighter than a feather.

You are not logged in.

#1 2015-09-15 17:59:41

Putte
Member
Registered: 2015-09-08
Posts: 18

A couple of more issues related to the search options

Hi,

I just discovered a couple of more issues related to the search options, which you may want to have a look at.

First the navbar search returns a broken URL, in my case like:

../search?action=search&keywords=XY

and it seems to be due to a wrong value in the action attribute of the opening tag of the form element (root of installation>featherbb>View>header.php, line 156, as of the present development version at GitHub). Presumeably the form tag should read something like:

<form method="get" action="<?php echo Url::base(); ?>/search/" class="nav-search">


and not:

<form method="get" action="/search" class="nav-search">


Secondly, the [New posts] link attached to the forum names on the front page (visible when you're logged in) apparently returns a wrong URL (error; page not found), in my case like:

../search/show/?action=show_new&fid=5/

It seems to me that this is due to a typo on: root-of-installation/featherbb/Model/index.php, line 183 (as of the present development version):

$forum_field_new = '<span class="newtext">[ <a href="'.$this->feather->urlFor('quickSearch', ['show' => '?action=show_new&amp;fid='.$cur_forum->fid]).'">'.__('New posts').'</a> ]</span>';


The search seems to work as expected and returns the appropriate topics with:

$forum_field_new = '<span class="newtext">[ <a href="'.$this->feather->urlFor('quickSearch', ['show' => 'new&amp;fid='.$cur_forum->fid]).'">'.__('New posts').'</a> ]</span>';


Putte

Offline

#2 2015-09-16 16:34:17

beaver
Administrator
From: France
Registered: 2015-07-03
Posts: 31

Re: A couple of more issues related to the search options

Hi,

We probably will change quick searches later to get rid of those ugly "?fid=X" in urls, but meanwhile your patch works perfectly, thank you ! Plugins branch has been updated with the fix, Development will follow soon.

Offline

Board footer

[ Generated in 0.069759 seconds, 6 queries executed - Memory usage: 1.41 MiB (Peak: 1.45 MiB) ]